Return an empty list by default in `pkg_resources.ResourceManager.c…

…leanup_resources` (#4244)
pypa · Mar 5, 2024 · ef6c7ab · ef6c7ab
2 parents 226e1a2 + 5b538e1
commit ef6c7ab
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/newsfragments/4244.bugfix.rst b/newsfragments/4244.bugfix.rst
@@ -0,0 +1 @@
+Return an empty `list` by default in ``pkg_resources.ResourceManager.cleanup_resources`` -- by :user:`Avasam`
diff --git a/pkg_resources/__init__.py b/pkg_resources/__init__.py
@@ -27,7 +27,7 @@
 import time
 import re
 import types
-from typing import Protocol
+from typing import List, Protocol
 import zipfile
 import zipimport
 import warnings
@@ -1339,7 +1339,7 @@ def set_extraction_path(self, path):
 
         self.extraction_path = path
 
-    def cleanup_resources(self, force=False):
+    def cleanup_resources(self, force=False) -> List[str]:
         """
         Delete all extracted resource files and directories, returning a list
         of the file and directory names that could not be successfully removed.
@@ -1351,6 +1351,7 @@ def cleanup_resources(self, force=False):
         directory used for extractions.
         """
         # XXX
+        return []
 
 
 def get_default_cache():