Append arbitrary args instead of prepending.

pypa · Feb 13, 2024 · 8585c5e · 8585c5e
1 parent e4cca0e
commit 8585c5e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/newsfragments/4217.bugfix.rst b/newsfragments/4217.bugfix.rst
@@ -0,0 +1,2 @@
+Fix argument order of ``--config-settings["--build-option"]`` arguments.
+This was broken by <https://github.com/pypa/setuptools/pull/4079>`.
diff --git a/setuptools/build_meta.py b/setuptools/build_meta.py
@@ -369,7 +369,7 @@ def prepare_metadata_for_build_wheel(
         return self._bubble_up_info_directory(metadata_directory, ".dist-info")
 
     def _build_with_temp_dir(
-        self, setup_command, result_extension, result_directory, config_settings
+        self, setup_command, result_extension, result_directory, config_settings, arbitrary_args=False
     ):
         result_directory = os.path.abspath(result_directory)
 
@@ -385,6 +385,8 @@ def _build_with_temp_dir(
                 "--dist-dir",
                 tmp_dist_dir,
             ]
+            if arbitrary_args:
+                sys.argv += self._arbitrary_args(config_settings)
             with no_install_setup_requires():
                 self.run_setup()
 
@@ -402,10 +404,11 @@ def build_wheel(
     ):
         with suppress_known_deprecation():
             return self._build_with_temp_dir(
-                ['bdist_wheel', *self._arbitrary_args(config_settings)],
+                ['bdist_wheel'],
                 '.whl',
                 wheel_directory,
                 config_settings,
+                True,
             )
 
     def build_sdist(self, sdist_directory, config_settings=None):