Work around platform.python_version() returning non PEP 440 compliant version for non-tagged CPython builds #802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
sbidoul
force-pushed
the
python_full_version-plus
branch
from
bf268e7
to
582ca41
Compare
sbidoul
force-pushed
the
python_full_version-plus
branch
from
582ca41
to
178ea2f
Compare
pradyunsg
approved these changes
May 19, 2024
pradyunsg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #678
Since #678 will make things difficult for pip 24.1 users using non-tagged python builds, I'm proposing this solution.
We could also work around it in pip but this would be messier and would not solve the problem for
packagingusers.CPython could also be changed, but it is likely more complex to achieve and probably not doable for older CPython versions.