Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify version split/join usage #725

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Clarify version split/join usage #725

merged 1 commit into from
Oct 3, 2023

Commits on Oct 2, 2023

  1. Clarify version split/join usage 

    This adds a docstring on _version_join to clarify its expectation on the
input value. Since this is a strictly internal function, I also removed
the assert statement so it does not fire at runtime and break user code.
If it ever does fire, it would be due to a bug in packaging and we
should fix it instead.

Both _version_split and _version_join also received slight refactoring.
    @uranusjr
    uranusjr committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    60a45e9 View commit details
    Browse the repository at this point in the history