Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix specifier matching when the specifier is long and has an epoch #712

Merged
merged 1 commit into from Oct 2, 2023
Merged

Fix specifier matching when the specifier is long and has an epoch #712

merged 1 commit into from Oct 2, 2023

Commits on Oct 1, 2023

  1. Fix specifier matching when the specifier is long and has an epoch 

    `_pad_version` assumes that all components that aren't numeric are
suffixes. But that assumption breaks when epoch numbers are present,
because `_version_split` outputs a component like "2!1".

Fix the assumption by making `_version_split` separate the epoch number
into its own component. Introduce `_version_join` to correctly join
the output of `_version_split` back into a string, which is needed by
`_compare_compatible`.

Fixes pypa#683
    @SpecLad
    SpecLad committed Oct 1, 2023
    Configuration menu
    Copy the full SHA
    c648bc0 View commit details
    Browse the repository at this point in the history