Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canonicalize names for requirements comparison #696

Merged
merged 7 commits into from Jul 7, 2023
Merged

Canonicalize names for requirements comparison #696

merged 7 commits into from Jul 7, 2023

Conversation

astrojuanlu
Copy link
Contributor

Fix gh-644.

@astrojuanlu astrojuanlu mentioned this pull request Jun 2, 2023
Open
@brettcannon
Copy link
Member

@astrojuanlu I don't have time right now for a review, but I did notice you have a file conflict.

@astrojuanlu

This comment was marked as resolved.

Sign in to view
@astrojuanlu astrojuanlu force-pushed the canonicalize-name-requirements-equality branch from ac53a24 to fd176f2 Compare June 19, 2023 05:59
@astrojuanlu
Copy link
Contributor Author

Rebased on top of current main.

@uranusjr
Copy link
Member

I think this needs an entry in CHANGELOG.

@astrojuanlu
Copy link
Contributor Author

Good catch, thanks. Updated.

@astrojuanlu astrojuanlu force-pushed the canonicalize-name-requirements-equality branch from 029e265 to 950c340 Compare June 26, 2023 18:39
@brettcannon brettcannon merged commit e8f839f into pypa:main Jul 7, 2023
30 checks passed
@brettcannon
Copy link
Member

Thanks!

@astrojuanlu astrojuanlu deleted the canonicalize-name-requirements-equality branch July 8, 2023 10:22
kodiakhq bot pushed a commit to cloudquery/plugin-sdk-python that referenced this pull request Nov 1, 2023
@cq-bot
fix(deps): Update dependency packaging to v23.2 (#81)
956db38 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [packaging](https://togithub.com/pypa/packaging) | minor | `==23.1` -> `==23.2` |

---

### Release Notes

<details>
<summary>pypa/packaging (packaging)</summary>

### [`v23.2`](https://togithub.com/pypa/packaging/releases/tag/23.2)

[Compare Source](https://togithub.com/pypa/packaging/compare/23.1...23.2)

#### What's Changed

-   parse_marker should consume the entire source string by [@&#8203;mwerschy](https://togithub.com/mwerschy) in [pypa/packaging#687
-   Create a Security Policy file  by [@&#8203;joycebrum](https://togithub.com/joycebrum) in [pypa/packaging#695
-   Add python 3.12 to CI by [@&#8203;mayeut](https://togithub.com/mayeut) in [pypa/packaging#689
-   Remove URL validation from requirement parsing by [@&#8203;uranusjr](https://togithub.com/uranusjr) in [pypa/packaging#684
-   Add types for packaging.version.\_Version by [@&#8203;hauntsaninja](https://togithub.com/hauntsaninja) in [pypa/packaging#665
-   Add PyPy 3.10 to CI by [@&#8203;mayeut](https://togithub.com/mayeut) in [pypa/packaging#699
-   Remove unused argument in `_manylinux._is_compatible` by [@&#8203;mayeut](https://togithub.com/mayeut) in [pypa/packaging#700
-   Canonicalize names for requirements comparison by [@&#8203;astrojuanlu](https://togithub.com/astrojuanlu) in [pypa/packaging#696
-   Add platform tag support for LoongArch by [@&#8203;loongson-zn](https://togithub.com/loongson-zn) in [pypa/packaging#693
-   Ability to install `armv7l manylinux/musllinux` wheels on `armv8l` by [@&#8203;mayeut](https://togithub.com/mayeut) in [pypa/packaging#690
-   Include CHANGELOG.rst in sdist by [@&#8203;astrojuanlu](https://togithub.com/astrojuanlu) in [pypa/packaging#704
-   Update pyupgrade to Python 3.7+ by [@&#8203;fangchenli](https://togithub.com/fangchenli) in [pypa/packaging#580
-   Fix version pattern pre-releases by [@&#8203;deathaxe](https://togithub.com/deathaxe) in [pypa/packaging#705
-   Fix typos found by codespell by [@&#8203;DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos) in [pypa/packaging#706
-   Support enriched metadata by [@&#8203;brettcannon](https://togithub.com/brettcannon) in [pypa/packaging#686
-   Correct rST syntax in CHANGELOG.rst by [@&#8203;atugushev](https://togithub.com/atugushev) in [pypa/packaging#709
-   fix: platform tag for GraalPy by [@&#8203;mayeut](https://togithub.com/mayeut) in [pypa/packaging#711
-   Document that this library uses a calendar-based versioning scheme by [@&#8203;faph](https://togithub.com/faph) in [pypa/packaging#717
-   fix: Update copyright date for docs by [@&#8203;garrypolley](https://togithub.com/garrypolley) in [pypa/packaging#713
-   Bump pip version to avoid known vulnerabilities by [@&#8203;joycebrum](https://togithub.com/joycebrum) in [pypa/packaging#720
-   Typing annotations fixed in version.py by [@&#8203;jolaf](https://togithub.com/jolaf) in [pypa/packaging#723
-   parse\_{sdist,wheel}\_filename: don't raise InvalidVersion by [@&#8203;SpecLad](https://togithub.com/SpecLad) in [pypa/packaging#721
-   Fix code blocks in CHANGELOG.md by [@&#8203;edmorley](https://togithub.com/edmorley) in [pypa/packaging#724

#### New Contributors

-   [@&#8203;mwerschy](https://togithub.com/mwerschy) made their first contribution in [pypa/packaging#687
-   [@&#8203;joycebrum](https://togithub.com/joycebrum) made their first contribution in [pypa/packaging#695
-   [@&#8203;astrojuanlu](https://togithub.com/astrojuanlu) made their first contribution in [pypa/packaging#696
-   [@&#8203;loongson-zn](https://togithub.com/loongson-zn) made their first contribution in [pypa/packaging#693
-   [@&#8203;fangchenli](https://togithub.com/fangchenli) made their first contribution in [pypa/packaging#580
-   [@&#8203;deathaxe](https://togithub.com/deathaxe) made their first contribution in [pypa/packaging#705
-   [@&#8203;DimitriPapadopoulos](https://togithub.com/DimitriPapadopoulos) made their first contribution in [pypa/packaging#706
-   [@&#8203;atugushev](https://togithub.com/atugushev) made their first contribution in [pypa/packaging#709
-   [@&#8203;faph](https://togithub.com/faph) made their first contribution in [pypa/packaging#717
-   [@&#8203;garrypolley](https://togithub.com/garrypolley) made their first contribution in [pypa/packaging#713
-   [@&#8203;jolaf](https://togithub.com/jolaf) made their first contribution in [pypa/packaging#723
-   [@&#8203;SpecLad](https://togithub.com/SpecLad) made their first contribution in [pypa/packaging#721
-   [@&#8203;edmorley](https://togithub.com/edmorley) made their first contribution in [pypa/packaging#724

**Full Changelog**: pypa/packaging@23.1...23.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok merwok left review comments

@brettcannon brettcannon brettcannon approved these changes

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Normalisation and Requirement's str()
4 participants
@astrojuanlu @brettcannon @uranusjr @merwok