Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update templates for new projects #624

Merged
merged 5 commits into from Nov 27, 2022
Merged

Update templates for new projects #624

merged 5 commits into from Nov 27, 2022

Conversation

ofek
Copy link
Sponsor Collaborator

@ofek ofek commented Nov 26, 2022 •
edited

Enforces absolute imports for easy addition of Mypyc if the user wants to eventually

@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2022 •
edited

Code Coverage

Package Statements
hatch 97.27% (3898 / 4007)
hatchling 97.48% (3294 / 3379)
tests 99.99% (12791 / 12792)
Summary 99.03% (19983 / 20178)

@blink1073
Copy link
Contributor

Out of curiosity, why remove coverage from the templates?

@ofek
Copy link
Sponsor Collaborator Author

ofek commented Nov 27, 2022

I only want to recommend workflows that have large buy-in or are not controversial and coverage via that plugin is often not the best nor easiest way for most users

@blink1073
Copy link
Contributor

Fair enough, thanks!

@ofek
Copy link
Sponsor Collaborator Author

ofek commented Nov 27, 2022

Though coverage is important... re-thinking

@blink1073
Copy link
Contributor

Looking at download stats, pytest-cov as 15M downloads in the last month and pytest has 47M, that feels well received to me. :)

@blink1073
Copy link
Contributor

I was about to comment, I actually just had to switch from pytest-cov to coverage run in this PR because the magic added by pytest-cov was causing the test suite to hang.

@ofek
Copy link
Sponsor Collaborator Author

ofek commented Nov 27, 2022

Coverage is back!

@ofek
Copy link
Sponsor Collaborator Author

ofek commented Nov 27, 2022

cc @charliermarsh to spot check default Ruff config

@ofek ofek merged commit 590db96 into master Nov 27, 2022
@ofek ofek deleted the t branch November 27, 2022 19:33
github-actions bot pushed a commit that referenced this pull request Nov 27, 2022
@ofek
Update templates for new projects (#624)
7171f88 
* Update templates for new projects

* add coverage

* final Ruff update

* fix

* back to pytest-cov for subprocesses and xdist 590db96
@ofek ofek mentioned this pull request Nov 30, 2022
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh charliermarsh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ofek @blink1073 @charliermarsh