Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action: replace internal-be-careful-debug #36

Merged
merged 3 commits into from
Mar 23, 2023
Merged

Conversation

tnytown
Copy link
Member

@tnytown tnytown commented Mar 23, 2023

Fixes #13.

Signed-off-by: Andrew Pan <a@tny.town>
@tnytown tnytown requested a review from woodruffw March 23, 2023 20:46
@tnytown
Copy link
Member Author

tnytown commented Mar 23, 2023

Hm, not sure why it thinks secrets.ACTIONS_STEP_DEBUG is undefined.

https://github.com/pypa/gh-action-pip-audit/actions/runs/4505069597/jobs/7930338262?pr=36#step:3:2

@woodruffw
Copy link
Member

Hm, not sure why it thinks secrets.ACTIONS_STEP_DEBUG is undefined.

It's an annoying restriction with action.yml -- it can only access the inputs namespace, not the secrets one.

If I'm right, we shouldn't need to do any special handling of ACTIONS_STEP_DEBUG at all -- GitHub will do it for us. We just need to document that we support it 🙂

action.yml Outdated Show resolved Hide resolved
Signed-off-by: Andrew Pan <a@tny.town>
Signed-off-by: Andrew Pan <a@tny.town>
@woodruffw woodruffw merged commit 1abec09 into pypa:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the built in debugging functionality in GHA?
2 participants