Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't preinstall setuptools and wheel, remove from constraints #1725

Merged
merged 6 commits into from
Feb 28, 2024

Commits on Jan 20, 2024

  1. Don't preinstall setuptools and wheel, remove from constraints

    Reasons to do this:
    
    - setuptools is no longer the only game in town. When cibuildwheel was created, setuptools was the only way to make wheels. these days, there are many build backends so special casing setuptools doesn't make so much sense
    - we don't need to preinstall `wheel` any more, setuptools will do that itself when it needs it.
    - projects with pyproject.toml (i.e. the vast majority of projects going forward) don't benefit from the pin anyway, because both `pip` and `build` create an isolated environment to install `build-system.requires` into.
    - this makes it easier for end users (such as @webknjaz) to control build-system versions using `PIP_CONSTRAINT`, because there's less potential for a user-specified version to conflict with one of our pins.
      - (long-term, I'd love `build` to [support this directly](pypa/build#292), and then we could have a proper way to keep pyproject.toml dependencies loose and forward-compatible while retaining build determinism. But PIP_CONSTRAINT is the best we have for now. PIP_CONSTRAINT isn't ideal because it affects other things, like the test virtualenv).
    
    This PR also adds a pin for pypa/build. It appears that was missing before, but we should pin it.
    joerick committed Jan 20, 2024
    Configuration menu
    Copy the full SHA
    9879937 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ca5d7c View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    7ada127 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    74afe32 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f04a522 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3ae9aa1 View commit details
    Browse the repository at this point in the history