fix: download pipx for action, allow support for M1 #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
|
@henryiii, hope it's okay, I pushed a couple commits to get this working. I hope that actions/setup-python wouldn't put spaces in the path! I want to do a quick release to get that Powershell fix in and I thought that we might as well let people try out the new macos-14 runners. We can do the official support with examples/docs in #1700. |
|
Erm, actually, on second thoughts maybe that's not a good assumption given 'Program Files' and all that. |
|
Great, thanks! Had to teach. That's what I was thinking, fixing the powershell plus macOS AS runners would be a good quick patch release. |
|
This won't break Travis, so fine to merge IMO. |
|
brill, thanks, releasing now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes an extra second or two, plus it could interfere with the environment a bit if someone activates the same version of Python. But not too bad.