Address #3182: Pixmap.invert_irect argument type error. #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorjMcKie
reviewed
Feb 20, 2024
src/__init__.py
Outdated
| @@ -16267,15 +16267,15 @@ def JM_irect_from_py(r): | |||
| r = mupdf.FzIrect( r.x0, r.y0, r.x1, r.y1) | |||
| return r | |||
| if isinstance(r, Rect): | |||
| ret = mupdf.fz_make_irect(r.x0, r.y0, r.x1, r.y1) | |||
| ret = mupdf.fz_make_irect(int(r.x0), int(r.y0), int(r.x1), int(r.y1)) | |||
There was a problem hiding this comment.
I don't think this is correct, because rounding is different from how MuPDF makes a IRect from a Rect: uppper and left coords must be rounded in direction left / up, but lower / right coords must take the next available integer ceiling.
There was a problem hiding this comment.
In principle we must first form Rect and then an IRect from the result: fz_irect_from_rect(fz_rect rect).
There was a problem hiding this comment.
Thanks, i hadn't realised that. New commit fixes hopefully.
JorjMcKie
reviewed
Feb 20, 2024
julian-smith-artifex-com
force-pushed
the
jules
branch
from
a8acf18
to
9983ce2
Compare
|
Have added a commit that addresses #3186. |
JorjMcKie
approved these changes
Feb 20, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #3182 and #3186.