-
Notifications
You must be signed in to change notification settings - Fork 129
Add conda developer environment for Mac ARM #941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah, hmm, indeed this is pretty awkward. The proposed changes will break things for those not on Apple Silicon. Ideally we should be doing something like depend on |
I couldn't get anything either to be totally honest. It doesn't seem like it's a lost battle, but it gets me deving on an m1 for now - though I fully intend for it to be a bit of wasted pr. I did see there was some conda like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would bake in accelerate instead of MKL, which we probably also don't want.
We figured out how to do this in the conda-forge package. https://github.com/conda-forge/pytensor-suite-feedstock/blob/main/recipe/meta.yaml Not sure it works here?
Alternatively we could add a different environment.yml for ARM64.
@twiecki yea, an alternative env file makes sense as well |
Multiple env files are indeed a straightforward and simple workaround. Those |
Sounds great, I'll go ahead and edit this to be |
I'd recommend calling it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach looks good for now. I think pixi would be able to handle this much more elegantly via features and multienvironments:
https://pixi.sh/latest/features/multi_environment/
But transitioning to pixi is a bit more involved, so let's get this merged for now.
Co-authored-by: Ben Mares <services-git-throwaway1@tensorial.com>
Can we get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Ch0ronomato! LGTM
Description
My work machine is an M2 mac with the apple silicon. Not sure if this is a machine y'all are planning on supporting, but these were the changes I needed to make to environment.yaml to get off the ground.
Related Issue
Checklist
Type of change