Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new tutorial on PRNGs with RandomVariables #928

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Added new tutorial on PRNGs with RandomVariables #928

merged 5 commits into from
Jul 17, 2024
+753 −0

Conversation

HangenYuu
Copy link
Contributor

Description

Added new tutorial on PRNGs with RandomVariables per @ricardoV94 suggestions.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

Sorry, something went wrong.

HangenYuu added 2 commits July 15, 2024 11:51
@HangenYuu
Initialized new tutorial on RandomVariables
Loading
Loading status checks…
fe5685c
@HangenYuu
Finished updating prng.rst
Loading
Loading status checks…
fe7f2e0
HangenYuu
HangenYuu commented Jul 15, 2024
View reviewed changes
Copy link
Contributor Author

@HangenYuu HangenYuu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also realized some minor erros in contributing documentation and dependencies need updating in environment.yml file. I will open separate PRs for ithem.

@HangenYuu HangenYuu mentioned this pull request Jul 15, 2024
Open
11 tasks
ricardoV94
ricardoV94 reviewed Jul 15, 2024
View reviewed changes
ricardoV94
ricardoV94 reviewed Jul 15, 2024
View reviewed changes
HangenYuu added 2 commits July 17, 2024 11:04
@HangenYuu
Updated all dprint outputs and minor edits.
Loading
Loading status checks…
5806331
@HangenYuu
Fixed typo
Loading
Loading status checks…
bc0b701
@ricardoV94
Copy link
Member

Looks good, but the Scipy snippet is not formatting correctly: https://pytensor--928.org.readthedocs.build/en/928/tutorial/prng.html#scipy

ricardoV94
ricardoV94 reviewed Jul 17, 2024
View reviewed changes
doc/tutorial/index.rst Outdated
@@ -59,6 +59,7 @@ Further reading
.. toctree::

loading_and_saving
prng
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be after sparse, in the advanced section above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the minor issues.

@HangenYuu
Fixed issues with ToC and SciPy format
Loading
Loading status checks…
7335439
@ricardoV94 ricardoV94 merged commit 6b8df2c into pymc-devs:main Jul 17, 2024
15 checks passed
@ricardoV94
Copy link
Member

Thanks @HangenYuu !

@HangenYuu HangenYuu deleted the prng_tutorial branch July 17, 2024 14:34
@ricardoV94 ricardoV94 mentioned this pull request Jul 17, 2024
Open
48 tasks
@HangenYuu
Copy link
Contributor Author

Thanks @HangenYuu !

No problem @ricardoV94!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardoV94 ricardoV94

@jessegrabowski jessegrabowski

Assignees
No one assigned
Labels
docs random variables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC: Extend documentation on RandomVariables
2 participants
@HangenYuu @ricardoV94