Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash for Enum class decorated with dataclass #9104

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/whatsnew/fragments/9100.other
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix a crash when an enum class which is also decorated with a ``dataclasses.dataclass`` decorator is defined.

Closes #9100
6 changes: 5 additions & 1 deletion pylint/checkers/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -2281,5 +2281,9 @@ def is_enum_member(node: nodes.AssignName) -> bool:
):
return False

enum_member_objects = frame.locals.get("__members__")[0].items
members = frame.locals.get("__members__")
# A dataclass is one known case for when `members` can be `None`
if members is None:
return False
enum_member_objects = members[0].items
return node.name in [name_obj.name for value, name_obj in enum_member_objects]
mbyrnepr2 marked this conversation as resolved.
Show resolved Hide resolved
9 changes: 9 additions & 0 deletions tests/functional/i/invalid/invalid_name/invalid_name_enum.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# pylint: disable=too-few-public-methods


from dataclasses import dataclass
from enum import Enum


Expand All @@ -28,3 +29,11 @@ def __init__(self, red: int, green: int, blue: int) -> None:
def as_hex(self) -> str:
"""Get hex 'abcdef' representation for a color."""
return f'{self.red:0{2}x}{self.green:0{2}x}{self.blue:0{2}x}'


@dataclass
class Something(str, Enum):
""" A false positive for ``invalid-name``
which should be fixed by https://github.com/pylint-dev/astroid/issues/2317
"""
ASD: str = 1 # [invalid-name]
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
invalid-name:16:4:16:14:Color:"Class constant name ""aquamarine"" doesn't conform to UPPER_CASE naming style":HIGH
invalid-name:17:4:17:14:Color:"Class constant name ""aquamarine"" doesn't conform to UPPER_CASE naming style":HIGH
invalid-name:39:4:None:None:Something:"Attribute name ""ASD"" doesn't conform to snake_case naming style":HIGH