Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create constant for default ignore list #6615

Merged
merged 1 commit into from
May 15, 2022
Merged

Create constant for default ignore list #6615

merged 1 commit into from
May 15, 2022

Conversation

DudeNr33
Copy link
Collaborator

  • Write a good description on what the PR does.
  • If you used multiple emails or multiple names when contributing, add your mails
    and preferred name in script/.contributors_aliases.json

Type of Changes

Type
✓ 🔨 Refactoring

Description

Follow up to @DanielNoord's comment:
#6614 (comment)

The same default value for ignore / black_list was used in three different places in the code base, so we can extract a constant for it.

@DudeNr33 DudeNr33 added the Maintenance Discussion or action around maintaining pylint or the dev workflow label May 15, 2022
@DudeNr33 DudeNr33 added this to the 2.14.0 milestone May 15, 2022
@DudeNr33 DudeNr33 requested a review from DanielNoord May 15, 2022 06:19
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2326348445

  • 4 of 4 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0008%) to 95.349%
Totals Coverage Status
Change from base Build 2326320106: 0.0008%
Covered Lines: 16052
Relevant Lines: 16835
💛 - Coveralls

Pierre-Sassoulas
Pierre-Sassoulas approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Pierre-Sassoulas Pierre-Sassoulas merged commit 3e643a0 into pylint-dev:main May 15, 2022
@DudeNr33 DudeNr33 deleted the ignore-default-constant branch May 15, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@DanielNoord DanielNoord Awaiting requested review from DanielNoord

Assignees
No one assigned
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DudeNr33 @coveralls @Pierre-Sassoulas