Respect py-version for inconsistent-quotes inside f-strings

[theirix]

Type of Changes

	Type
✓	🐛 Bug fix
	✨ New feature
	🔨 Refactoring
✓	📜 Docs

Description

When running pre-3.12 interpeter, f-strings are opaque and are represented as a STRING token (like 'f'{dictionary["0"]}' for the test case in the ticket). So they are not used in analysis.

With 3.12 PEG interpreter, f-string is a proper Python expression, even if we target pre-3.12. So this PR enables inconsistent-quotes checks for string literals only if a target version is 3.12 or later.

Closes #9113

[codecov]

Codecov Report

Merging #9152 (720de79) into main (0796dfa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9152   +/-   ##
=======================================
  Coverage   95.76%   95.76%           
=======================================
  Files         173      173           
  Lines       18680    18690   +10     
=======================================
+ Hits        17889    17899   +10     
  Misses        791      791           

Files	Coverage Δ
pylint/checkers/strings.py	94.27% <100.00%> (+0.13%)	⬆️

[github-actions]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 720de79

[Pierre-Sassoulas]

Great contribution. Maybe the following could be added in the message definition: {"maxversion": (3, 12)}, (see

pylint/pylint/checkers/async.py

Line 31 in 0796dfa

{"minversion": (3, 5)},

and

pylint/pylint/message/message_definition.py

Line 77 in 0796dfa

if self.minversion is not None and self.minversion > py_version:

). This should simplify the sys.version_info check too?

[theirix]

Great contribution. Maybe the following could be added in the message definition: {"maxversion": (3, 12)}, (see

pylint/pylint/checkers/async.py

Line 31 in 0796dfa

{"minversion": (3, 5)},

Thank you!

I am not sure if we can add a version limit to the message "W1405 inconsistent-quotes" definition itself because this PR addresses only differences with f-strings handling. Other problems with inconsistent quotes are not related to Python version so they cannot be dispatched from message definition.

Maybe if we have inconsistent-quotes-f-strings, it could be easily added to message definition.

[Pierre-Sassoulas]

Hmm you're right, probably not worth the very small perf/maintance improvment then.