removes more false positives for unused-argument #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
…ter-unused-argument # By Stavros Ntentos (15) and others # Via GitHub (9) and Stavros Ntentos (1) * origin/master: Release v1.1.3 Fixing _is_pytest_fixture test direct import Improve packaging + Release v1.1.3rc1 Release v1.1.3rc0 (pylint-dev#17) Fix testing + coverage Improvements for `.github/workflows/run-tests.yaml` Fix the repository badges Roll back `from __future__ import annotations` for Python 3.6 Fix mypy issues Activate mypy in pre-commit [mypy] Fix Item "None" of "Optional[Module]" has no attribute "__file__" Carry over some `.pylintrc` configuration Minor re-ordering of the `tool.pylint`, with some comments Move the pylint configuration to pyproject.toml [pylint] Add pylint in the continuous integration and pre-commit Activate ruff, ignore the typing of classvar Upgrade the changelog for 1.1.3a0 release (pylint-dev#10) Use ruff instead of flake8 pyupgrade autoflake and isort Enable https://github.com/asottile/pyupgrade + `.git-blame-ignore-revs` `pre-commit run -a` Add `.pre-commit-config.yaml` Add a release job to publish on pypi on github tag creation MOAR Improvements: Cross-OS testing, `.gitignore` updates, supporting only `pylint<3`, coverage at Codecov, drop other CI CI: Modernize, MOAR Pythons, GH-Actions Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com> # Conflicts: # pylint_pytest/checkers/fixture.py
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #21 +/- ##
==========================================
+ Coverage 92.03% 92.16% +0.13%
==========================================
Files 18 18
Lines 527 536 +9
Branches 99 104 +5
==========================================
+ Hits 485 494 +9
Misses 29 29
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…fixname][0].argnames:` Signed-off-by: Stavros Ntentos <133706+stdedos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Parsons nate@planet.com
Replayed on https://github.com/pylint-dev/pylint-pytest:
nsp/nate/better-unused-argumentmerge-able withorigin/master(360461c)if node.name in FixtureChecker._pytest_fixtures[fixname][0].argnames:(8756cc4)Signed-off-by: Stavros Ntentos 133706+stdedos@users.noreply.github.com