🧼🫧 Fix shape handling in Interaction #1459
Merged
+35
−46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR cleans up inconsistencies in how we handle symbolic shapes in
Interaction
.It now uses
entity_shape
as the shape information for all entity representations (head & tail).head_indices
andtail_indices
can be used to derive the shapes for a given role, exposed as propertieshead_shape
andtail_shape
.It also lifts the restriction of only using interactions with shared head and entity shape via the
interaction
+dimensions
API insidepipeline
, and converts the class methodget_dimensions
to an instance-propertydimensions
which now also supports interaction with variable number of representations, e.g., AutoSF.Follow up:
I think it makes sense to change the generic type of
ERModel[HeadRepresentation, RelationRepresentation, TailRepresentation]
toERModel[EntityRepresentation, RelationRepresentation]
and only distinguish in the interaction.