Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️⚙️ Re-use AMO for predict_triples_df #1089

Merged
merged 7 commits into from
Aug 25, 2022
Merged

Conversation

mberr
Copy link
Member

@mberr mberr commented Aug 25, 2022

This PR re-uses the torch_max_mem package for automatic batch size selection for predict_triples_df.

@mberr mberr changed the title re-use AMO for predict_triples_df ♻️⚙️ re-use AMO for predict_triples_df Aug 25, 2022
@cthoyt cthoyt changed the title ♻️⚙️ re-use AMO for predict_triples_df ♻️⚙️ Re-use AMO for predict_triples_df Aug 25, 2022
@mberr mberr marked this pull request as ready for review August 25, 2022 11:57
@mberr mberr marked this pull request as draft August 25, 2022 12:55
@mberr mberr marked this pull request as ready for review August 25, 2022 12:55
@cthoyt
Copy link
Member

cthoyt commented Aug 25, 2022

Don't worry about the failing test, it was a temporary connection issue in intersphinx.

mberr added 2 commits August 25, 2022 15:50
@mberr mberr requested a review from cthoyt August 25, 2022 14:00
@mberr mberr mentioned this pull request Aug 25, 2022
1 task
@mberr mberr enabled auto-merge (squash) August 25, 2022 14:11
@mberr mberr merged commit 8d06117 into master Aug 25, 2022
@mberr mberr deleted the upgrade-predict-triples branch August 25, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants