Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac Os - pympipool: Use localhost for connection rather than the network address #1390

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Mar 19, 2024

While this is primarily a Github related issues as discussed in actions/runner-images#8649 and local versions run fine. I now disabled the support for multiple nodes on macOS, as most computer clusters use Linux anyway. This is the same issue we discussed in pympipool in pyiron/pympipool#258

@jan-janssen jan-janssen added the format_black reformat the code using the black standard label Mar 19, 2024
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. The explanatory comment is solid.

@jan-janssen jan-janssen merged commit 0efd4e5 into main Mar 19, 2024
25 checks passed
@jan-janssen jan-janssen deleted the mac_hostname branch March 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black reformat the code using the black standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSX 12 tests are sometime timing out
3 participants