Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SSA which is not used and not maintained #1105

Merged
merged 2 commits into from
Jul 8, 2023
Merged

Remove SSA which is not used and not maintained #1105

merged 2 commits into from
Jul 8, 2023

Conversation

samwaseda
Copy link
Member

There is currently anyway no possibility to combine SSA and SxExtOpt.

@coveralls
Copy link

coveralls commented Jul 6, 2023 •
edited

Pull Request Test Coverage Report for Build 5477020183

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 67.621%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/interactive/sxextoptint.py 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/interactive/sxextoptint.py 4 32.84%
Totals Coverage Status
Change from base Build 5473087282: 0.02%
Covered Lines: 11167
Relevant Lines: 16514
💛 - Coveralls

@jan-janssen
Copy link
Member

Does this affect the functionality we published in https://github.com/pyiron/spin_space_averaging ?

@samwaseda
Copy link
Member Author

Does this affect the functionality we published in https://github.com/pyiron/spin_space_averaging ?

No because it’s not based on SxExtOpt

@samwaseda samwaseda merged commit 0697a82 into main Jul 8, 2023
24 checks passed
@delete-merged-branch delete-merged-branch bot deleted the sxextopt_remove_ssa branch July 8, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samwaseda @coveralls @jan-janssen