Fix GLSL and HLSL preprocessor line continuation #2350
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both shading languages allow their preprocessor to use line continuation with backlashes
\
, if they are the last character on a line before newline or carriage return. This PR adds support for that:Noticed this problem when generating Godot's documentation for its shader preprocessor (which is very similar to GLSL and HLSL preprocessor). Notice how the first shader code block in https://docs.godotengine.org/en/latest/tutorials/shaders/shader_reference/shader_preprocessor.html does not get syntax highlighting at all as the current lexer produces an error because of
\
characters. This PR fixes the issue and the code block is highlighted correctly.