Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pygments to 2.15.1 and restore fixed shader syntax highlighting #7436

Merged
merged 1 commit into from
May 30, 2023

Conversation

bitsawer
Copy link
Member

@bitsawer bitsawer commented May 29, 2023

Updates pygments to 2.15.1 now that PR's pygments/pygments#2350 and pygments/pygments#2357 have been merged and tested in the wild for a while. Also restores the GLSL syntax highlighting to the previously buggy codeblocks that those PR's fixed.

I did a clean build and everything seems to work with no warnings or errors. If you are testing locally, remember to upgrade your packages (pip install -U -r requirements.txt or pip3).

code

Docs team note: if this ends up fine, investigate cherrypicking to 3.x branches, maybe.

@mhilbrunner mhilbrunner added enhancement dependencies Pull requests that update a dependency file labels May 29, 2023
Copy link
Member

@Piralein Piralein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only tested the two affected examples, both work.

@mhilbrunner mhilbrunner merged commit d410ace into godotengine:master May 30, 2023
1 check passed
@mhilbrunner
Copy link
Member

Lets test it on RTD then. Thanks! And thanks for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants