Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert requester argument type in Auth #2912

Merged
merged 1 commit into from Mar 8, 2024
Merged

Conversation

EnricoMi
Copy link
Collaborator

@EnricoMi EnricoMi commented Mar 3, 2024

Type of requester argument is not asserted in github.Auth. This fixes this and removes some redundant assertions.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.70%. Comparing base (af529ab) to head (35f5c16).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
- Coverage   96.70%   96.70%   -0.01%     
==========================================
  Files         147      147              
  Lines       14885    14877       -8     
==========================================
- Hits        14395    14387       -8     
  Misses        490      490              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EnricoMi
Copy link
Collaborator Author

EnricoMi commented Mar 5, 2024

CC @JLLeitschuh

Copy link
Collaborator

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnricoMi EnricoMi merged commit 0b8435f into main Mar 8, 2024
15 checks passed
@EnricoMi EnricoMi deleted the auth-requester-assertions branch March 8, 2024 19:46
@EnricoMi
Copy link
Collaborator Author

EnricoMi commented Mar 8, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants