Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert requester argument type in Auth #2912

Merged
merged 1 commit into from Mar 8, 2024
Merged

Assert requester argument type in Auth #2912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 12 additions & 20 deletions github/Auth.py
View file
Open in desktop
Expand Up @@ -280,6 +280,7 @@ def __init__(
assert isinstance(app_auth, AppAuth), app_auth
assert isinstance(installation_id, int), installation_id
assert token_permissions is None or isinstance(token_permissions, dict), token_permissions
assert requester is None or isinstance(requester, Requester), requester

self._app_auth = app_auth
self._installation_id = installation_id
Expand All @@ -289,6 +290,7 @@ def __init__(
self.withRequester(requester)

def withRequester(self, requester: Requester) -> "AppInstallationAuth":
assert isinstance(requester, Requester), requester
super().withRequester(requester.withAuth(self._app_auth))

# imported here to avoid circular import
Expand Down Expand Up @@ -373,26 +375,14 @@ def __init__(
) -> None:
super().__init__()

assert isinstance(client_id, str)
assert len(client_id) > 0
assert isinstance(client_secret, str)
assert len(client_secret) > 0
assert isinstance(token, str)
assert len(token) > 0
if token_type is not None:
assert isinstance(token_type, str)
assert len(token_type) > 0
assert isinstance(token, str)
if token_type is not None:
assert isinstance(token_type, str)
assert len(token_type) > 0
if expires_at is not None:
assert isinstance(expires_at, datetime)
if refresh_token is not None:
assert isinstance(refresh_token, str)
assert len(refresh_token) > 0
if refresh_expires_at is not None:
assert isinstance(refresh_expires_at, datetime)
assert isinstance(client_id, str) and len(client_id) > 0
assert isinstance(client_secret, str) and len(client_secret) > 0
assert isinstance(token, str) and len(token) > 0
assert token_type is None or isinstance(token_type, str) and len(token_type) > 0, token_type
assert expires_at is None or isinstance(expires_at, datetime), expires_at
assert refresh_token is None or isinstance(refresh_token, str) and len(refresh_token) > 0
assert refresh_expires_at is None or isinstance(refresh_expires_at, datetime), refresh_expires_at
assert requester is None or isinstance(requester, Requester), requester

self._client_id = client_id
self._client_secret = client_secret
Expand All @@ -416,6 +406,7 @@ def token(self) -> str:
return self._token

def withRequester(self, requester: Requester) -> "AppUserAuth":
assert isinstance(requester, Requester), requester
super().withRequester(requester.withAuth(None))

# imported here to avoid circular import
Expand Down Expand Up @@ -494,6 +485,7 @@ def password(self) -> str:
return self._password

def withRequester(self, requester: Requester) -> "NetrcAuth":
assert isinstance(requester, Requester), requester
super().withRequester(requester)

auth = utils.get_netrc_auth(requester.base_url, raise_errors=True)
Expand Down