Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A property to access the assets field of release (#1898) #1899

Closed
wants to merge 1 commit into from
Closed

A property to access the assets field of release (#1898) #1899

wants to merge 1 commit into from

Conversation

green-green-avk
Copy link
Contributor

... in order to avoid extra requests.

#1898

@green-green-avk green-green-avk marked this pull request as draft March 28, 2021 04:13
@green-green-avk green-green-avk marked this pull request as ready for review March 28, 2021 04:13
@green-green-avk green-green-avk mentioned this pull request Mar 28, 2021
Closed
s-t-e-v-e-n-k
s-t-e-v-e-n-k requested changes Mar 28, 2021
View reviewed changes
Copy link
Collaborator

@s-t-e-v-e-n-k s-t-e-v-e-n-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking like a good start, I have one niggle inline, and this requires a test -- if the existing replay data used in tests/GitRelease.py already has assets, then you can assert that and you're golden.

github/GitRelease.py
@property
def assets(self):
"""
Already returned assets info (no additional requests will be done).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the :type: here, please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where to put a note on the difference between get_assets() and assets though?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... Hmm...

Just the :type: here, please

How then it should be mentioned which methods do additional requests and which not?
Sorry to remind but GitHub has limits...

@stale
Copy link

stale bot commented Jan 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 8, 2022
@stale stale bot closed this Apr 16, 2022
@Felixoid Felixoid mentioned this pull request Dec 20, 2022
Merged
sfdye pushed a commit that referenced this pull request Jan 30, 2023
@Felixoid @green-green-avk
Continue the PR #1899 (#2386)
7cf3dfc 
* A property to access the `assets` field of release (#1898)

... in order to avoid extra requests.

<#1898>

* Remove comment to comply the review

* Add tests for GitRelease.assets

---------

Co-authored-by: green-green-avk <45503261+green-green-avk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-t-e-v-e-n-k s-t-e-v-e-n-k s-t-e-v-e-n-k requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@green-green-avk @s-t-e-v-e-n-k