Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access the assets field in releases response to avoid extra requests #1898

Closed
green-green-avk opened this issue Mar 28, 2021 · 3 comments
Closed

Access the assets field in releases response to avoid extra requests #1898

green-green-avk opened this issue Mar 28, 2021 · 3 comments
Labels
stale

Comments

@green-green-avk
Copy link
Contributor

  1. A response to GET /repos/{owner}/{repo}/releases already contains an assets list for each release.
  2. GitHub has Rate limiting.

So, it's better to have an ability to access this list.
green-green-avk added a commit to green-green-avk/PyGithub that referenced this issue Mar 28, 2021
@green-green-avk
A property to access the assets field of release (PyGithub#1898)
d03d3ce 
... in order to avoid extra requests.

<PyGithub#1898>
@green-green-avk green-green-avk mentioned this issue Mar 28, 2021
Closed
@green-green-avk
Copy link
Contributor Author

Pull request: #1899

@stale
Copy link

stale bot commented Jan 9, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 9, 2022
@stale stale bot closed this as completed Apr 16, 2022
@Felixoid
Copy link
Contributor

The issue is not solved yet and the PR wasn't merged

@Felixoid Felixoid mentioned this issue Dec 20, 2022
Merged
sfdye pushed a commit that referenced this issue Jan 30, 2023
@Felixoid @green-green-avk
Continue the PR #1899 (#2386)
7cf3dfc 
* A property to access the `assets` field of release (#1898)

... in order to avoid extra requests.

<#1898>

* Remove comment to comply the review

* Add tests for GitRelease.assets

---------

Co-authored-by: green-green-avk <45503261+green-green-avk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Felixoid @green-green-avk