draw.aacircle() #2800
Merged
draw.aacircle() #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…draw.circle() - Added algorithms for drawing thin and thick antialiased circles, adapted from: https://cgg.mff.cuni.cz/~pepca/ref/WU.pdf - Added to documentation - Added to code_examples - Added to tests
|
Looks like you need to run |
oddbookworm
reviewed
Apr 14, 2024
Comment on lines
+34
to
+44
| def aacircle( | ||
| surface: Surface, | ||
| color: ColorValue, | ||
| center: Coordinate, | ||
| radius: float, | ||
| width: int = 0, | ||
| draw_top_right: bool = False, | ||
| draw_top_left: bool = False, | ||
| draw_bottom_left: bool = False, | ||
| draw_bottom_right: bool = False, | ||
| ) -> Rect: ... |
There was a problem hiding this comment.
I think it would actually be better to have two signatures here. One without the bools, and one with
There was a problem hiding this comment.
Why? circle above just has one signature.
1 task
- Run `python setup.py format` - Added another signature to buildconfig/stubs/pygame/draw.pyi - Removed unnecesary doubles - Renamed eight_pixels function - Post-increment -> pre-increment - Renamed method names and the docstrings to use aacircle Note: `python setup.py format` formatted some other files I havent touched.
oddbookworm
requested changes
Apr 15, 2024
fixed pre-increment added @overload to stubs
Starbuck5
reviewed
Apr 21, 2024
oddbookworm
requested changes
Apr 26, 2024
yunline
added
New API
oddbookworm
approved these changes
May 20, 2024
MyreMylar
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pygame-ce has only
gfxdraw.aacirclefunction for drawing antialiased circles, but it has several problems:Related issue: Add line thickness in gfxdraw #2463
Related issue: gfxdraw.aacircle weird lines when large radius #2450
and it is intended to be deprecated/removed in future.
All these problems are fixed in
draw.aacircle, that is implemented in this commit.Changes:
draw.aacirclefunction that has same inputs and outputs asdraw.circlehttps://cgg.mff.cuni.cz/~pepca/ref/WU.pdf