Improve safe chunk validation #9559
Merged
+312
−54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com>
…unk and raise a proper error based on the mode selected, it is also possible to use the auto region detection with the mode "a"
for more information, see https://pre-commit.ci
…nto improve-safe-chunk-validation
…ameter in order on the extract_zarr_variable_encoding method, raise the correct error if the border size is smaller than the zchunk on mode equal to r+
…ameter in order on the extract_zarr_variable_encoding method, raise the correct error if the border size is smaller than the zchunk on mode equal to r+
for more information, see https://pre-commit.ci
…nto improve-safe-chunk-validation # Conflicts: # xarray/tests/test_backends.py
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
5 tasks
|
Thank you for the very fast fix @josephnowak ! |
|
Thanks Joseph! I've confirmed that this has fixd the Xarray-Beam issue. |
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the error reported on #9557, it was an issue with the way that I tried to detect if the region was covering the last chunk
whats-new.rstapi.rst