Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Version dropdown redirection. #947

Closed
wants to merge 1 commit into from

Conversation

choldgraf
Copy link
Collaborator

@choldgraf choldgraf commented Sep 25, 2022

This is a re-implementation of the previous version redirect PR, because it was out of date and because we had changed how the configuration structure should work.


For all documentation pages on a different version, a large warning banner will be displayed stating that they they are on an out-of-date version, with a button to direct them to the preferred version.

Specify that an outdated version is a *development* version
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Specify that an outdated version is a *development* version
Specify that a version is a *development* version

@@ -18,7 +18,7 @@

from .bootstrap_html_translator import BootstrapHTML5Translator

__version__ = "0.10.1"
__version__ = "0.10.1dev0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
__version__ = "0.10.1dev0"
__version__ = "0.11.0dev0"

@@ -78,6 +78,10 @@
</nav>
{% endblock %}

{# Versoin warning placeholder that is replaced by the switcher JS #}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{# Versoin warning placeholder that is replaced by the switcher JS #}
{# Version warning placeholder that is replaced by the switcher JS #}

@drammock
Copy link
Collaborator

superseded by #1395

@drammock drammock closed this Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[proposal] Warning banners configuration structure Support for loud version warning banners
4 participants