Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update package-lock.json #1534

Merged
merged 1 commit into from Oct 23, 2023
Merged

update package-lock.json #1534

merged 1 commit into from Oct 23, 2023

Conversation

drammock
Copy link
Collaborator

@drammock drammock commented Oct 20, 2023 •
edited

#1508 bumped css-loader version in package.json but forgot to also update package-lock.json. This remedies that oversite (by running npm update and commiting the resulting changes).

closes #1533 (this change should obviate the dependabot complaint)

@drammock drammock added the kind: maintenance Improving maintainability and reducing technical debt label Oct 20, 2023
12rambau
12rambau approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@12rambau 12rambau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok now that all the tests are green, I guess merging is possible without breaking everything.

@12rambau 12rambau merged commit 97aa6b6 into pydata:main Oct 23, 2023
19 checks passed
@drammock drammock deleted the update-package-lock branch October 25, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12rambau 12rambau 12rambau approved these changes

Assignees
No one assigned
Labels
kind: maintenance Improving maintainability and reducing technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drammock @12rambau