test: add a codecov token to the coverage pipeline #1519

12rambau · 2023-10-17T15:23:31Z

I added a codecov token to the github action secret variable to avoid the error we get on regular basis in our CI.

definitive fix to #1311

* BUG - Clear alt_text in conf.py (pydata#1471) * comment out alt_text in conf.py * set alt_text to empty string * remove alt_text from conf.py * fix: use 12rambau fork until it's merged with nikeee repo (pydata#1517) * deps: drop support for Sphinx 5 (pydata#1516) * remove ref to myst-nb * update minimal supported version of sphinx * Fix: (webpack.config.js) css-loader API change (pydata#1508) * Fix: (webpack.config.js) css-loader API change The build was broken in <https://github.com/pydata/pydata-sphinx-theme/commit/185a37aa36820f77bffa4c87a772092e9e7cc380>/<https://github.com/pydata/pydata-sphinx-theme/pull/1494>. This change fixes the build, and it seems to be in accordance with the current API as described at <https://github.com/webpack-contrib/css-loader/blob/c6f36cf91ac61743a70e81cfb077faa0f8730ebe/README.md#boolean>. Closes <pydata#1507>. * dedup * restore version bump --------- Co-authored-by: Daniel McCloy <dan@mccloy.info> * Fix duplicate HTML IDs (pydata#1425) * Fix duplicate HTML IDs * fix tests * Do not animate the version admonitions colors. (pydata#1424) Otherwise a delay has to be added to the accessibility color contrast checks, to wait for the colors to fully transition. * BUG - Remove redundant ARIA in breadcrumb navigation (pydata#1426) * style(i18n): French Typo fixed (pydata#1430) * Add the ability to add a center section to the footer (pydata#1432) * Add a center section for the footer * Add docs for footer_center * Add a test site for the center footer * test it in our own docs * remove new test site * add footer test --------- Co-authored-by: Daniel McCloy <dan@mccloy.info> * Build(deps): Bump actions/checkout from 3 to 4 (pydata#1433) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add dropdown_text argument to generate_header_nav_html (pydata#1423) * Add dropdown_text argument to generate_header_nav_html * Add a test, fix typo in theme.conf and remove header_dropdown_text from docs/conf.py * fixed? --------- Co-authored-by: Daniel McCloy <dan@mccloy.info> * fix: rollback ref and Id changes (pydata#1438) * bump: version 0.13.3 → 0.14.0 (pydata#1440) * bump version * update version switcher * back to dev * fix: change the z-index of the dropdown (pydata#1442) In order to be on top of the primary sidebar on small screens. * fix: set the same background for dark/light (pydata#1443) * fix: set the same background for dark/light et the same background color for all state of the search field. It is currently only applied when hovered * fix: wrong css selector * Update src/pydata_sphinx_theme/assets/styles/components/_search.scss * Update src/pydata_sphinx_theme/assets/styles/components/_search.scss * Fix duplicate HTML IDs * fix tests * unique_html_id * backwards-compat generate_header_nav_html * feedback review * update fixture * ughhhh...caching * code cleanup * fix test snapshot * put comment inside def --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Denis Bitouzé <dbitouze@wanadoo.fr> Co-authored-by: Stuart Mumford <stuart@cadair.com> Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com> Co-authored-by: Rambaud Pierrick <12rambau@users.noreply.github.com> * chore: build the devcontainer automatically in codespace (pydata#1483) * chore: build the devcontainer automaticallyin codespace * refactor: lint * add pandoc to the environment * Fix font color in search input box (pydata#1524) * Fix color * Use --pst-color-text-base * docs: add DecentralChain (pydata#1528) Co-authored-by: jourlez <josuecr.288@gmail.com> * Updates for file src/pydata_sphinx_theme/locale/en/LC_MESSAGES/sphinx.po in ru [Manual Sync] (pydata#1527) i18n: Translate sphinx.po in ru [Manual Sync] 96% of minimum 20% translated source file: 'sphinx.po' on 'ru'. Sync of partially translated files: untranslated content is included with an empty translation or source language content depending on file format Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com> * ignore transient errors in windows build CI (pydata#1520) * use warning list * clean up notebook * refactor to pass on all platforms? * simplify * fix logic * iterate backwards * fix plaform detection? also don't log unnecessarily�[H * ignore empty string warnings * remove notebook metawarning * Revert "remove notebook metawarning" This reverts commit 42f4672. * try again * debug the mysterious empty warning * escape color codes * import * triage by intermittency, not by platform; better var names * simplify * fix list.remove * undo what I broke * Update tests/utils/check_warnings.py --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: gabalafou <gabriel@fouasnon.com> Co-authored-by: Adam Porter <adam@alphapapa.net> Co-authored-by: Daniel McCloy <dan@mccloy.info> Co-authored-by: Denis Bitouzé <dbitouze@wanadoo.fr> Co-authored-by: Stuart Mumford <stuart@cadair.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com> Co-authored-by: Harutaka Kawamura <hkawamura0130@gmail.com> Co-authored-by: jourlez <josuecr.288@gmail.com> Co-authored-by: transifex-integration[bot] <43880903+transifex-integration[bot]@users.noreply.github.com>

drammock · 2023-10-20T19:51:28Z

.github/workflows/tests.yml

@@ -91,12 +88,12 @@ jobs:
          pip install nox
          nox -s compile
      - name: Run tests
-        run: pytest -m "not a11y" --color=yes --cov pydata_sphinx_theme --cov-branch --cov-report xml:cov.xml --cov-report= --cov-fail-under ${{ env.COVERAGE_THRESHOLD }}
+        run: pytest -m "not a11y" --color=yes --cov --cov-report=xml


this doesn't look right to me:

the second --cov-report= with no argument is supposed to suppress the coverage output in the terminal output (which we don't need because we're generating XML and then viewing it through CodeCov website)

I think we still want --branch (can be branch = true under tool.coverage.run in the TOML file if you prefer)

I prefer to limit the number of parameter in the github actions so that we can rely exclusively on the nox session in the future. I'll add them to the TOML file

I checked the difference between the output of the current main and this branch and I don't see the difference in term of terminal output:

@drammock, are you sure the second --cov-report is really changing anything in the terminal output? (left is the current PR, right is the current main)

Weird, that's what is supposed to happen according to the docs but I agree that it's definitely not looking different. 🤷🏻

12rambau added 5 commits October 17, 2023 15:22

test: add a codecov token to the coverage pipeline

7b28471

trigger CI

b1ef5ec

fix: use default filename

e106b64

fix: stop checking branches as codecov don't display them

26478b4

refactor: set fail_under parameter in pyproject

85b91b4

12rambau marked this pull request as ready for review October 18, 2023 12:22

12rambau and others added 2 commits October 19, 2023 14:05

Merge branch 'pydata:main' into codecov

6b1c838

12rambau requested a review from drammock October 20, 2023 15:09

drammock reviewed Oct 20, 2023

View reviewed changes

test branch coverage

415841d

drammock merged commit 08ca29a into pydata:main Oct 23, 2023
19 checks passed

12rambau deleted the codecov branch October 23, 2023 11:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add a codecov token to the coverage pipeline #1519

test: add a codecov token to the coverage pipeline #1519

12rambau commented Oct 17, 2023 •

edited

drammock Oct 20, 2023

12rambau Oct 23, 2023

12rambau Oct 23, 2023

drammock Oct 23, 2023

test: add a codecov token to the coverage pipeline #1519

test: add a codecov token to the coverage pipeline #1519

Conversation

12rambau commented Oct 17, 2023 • edited

drammock Oct 20, 2023

Choose a reason for hiding this comment

12rambau Oct 23, 2023

Choose a reason for hiding this comment

12rambau Oct 23, 2023

Choose a reason for hiding this comment

drammock Oct 23, 2023

Choose a reason for hiding this comment

12rambau commented Oct 17, 2023 •

edited