Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set back align content for header navbar #1331

Merged
merged 3 commits into from May 30, 2023
Merged

Conversation

12rambau
Copy link
Collaborator

Fix #1235

I added a class to navbar_start to make sure "content" parameter works again. checked on our documentation.

right:

image

left:

image

content:

image

@drammock
Copy link
Collaborator

Can we add a regression test so we'll know if this ever breaks again?

Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think the regression test is basically what we're already doing via pytest-regressions on the header HTML. I suspect we introduced this bug in a bigger refactor and so missed that this class needed to exist in the new spot.

@12rambau
Copy link
Collaborator Author

the bug is introduced by a higher level in the tree let me edit the regression test so that it grasp the correct html elements

@12rambau 12rambau merged commit 181edb6 into pydata:main May 30, 2023
16 checks passed
@12rambau 12rambau deleted the align branch May 30, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The content of "navbar-center" appears directly after the logo
3 participants