Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove index.html from version switcher example. #1279

Merged
merged 1 commit into from Apr 4, 2023

Conversation

stefmolin
Copy link
Contributor

@stefmolin stefmolin commented Apr 2, 2023

When following the example in the docs for the switcher.json file, I ended up with issues once I tried to navigate to other pages because the index.html part stays in the URL (e.g., clicking on api goes to https://mysite.org/en/2.1/index.htmlapi.html). Removing index.html and ending with a trailing slash seems to be the fix (see also the Matplotlib switcher.json file).

@stefmolin stefmolin changed the title BUG: Remove index.html from version switcher example. FIX: Remove index.html from version switcher example. Apr 2, 2023
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed this seems like the right fix! Thanks @stefmolin

@drammock drammock merged commit 6f0cc3c into pydata:main Apr 4, 2023
14 checks passed
@stefmolin stefmolin deleted the patch-1 branch April 4, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants