FIX: Fix search icons displayed outside with small base font size #1278
Conversation
When `--pst-font-size-base` is small (i.e. 12px) the search icons (magnifying-glass and keyboard shortcut hint) could appear outside the search bar because their positions did not take the negative margins of their parent container into account. Use css `calc()` to include it now. TBH I don't know why a padding + negative margin is employed on the form element. Online I found that this technique can be used to make just one element (like a header) not constrained by the padding, but here there is only one child element (the `<form>`). The commit history doesn't help either the stylesheet had this since it's first version.
|
I also have no idea why the container has padding + negative margin. The resultant CSS is... complicated to say the least. Are you willing to try to simplify this bit of CSS (i.e., get rid of the negative margins and adjust what's left accordingly), or are you happy to just have it looking good again? |
Sure I have checked it out before that it would work, just didn't know if there was any reason why it was the way it was. See latest commit |
|
@Maetveis you'll need to merge in current |
I don't remember disabling the allow pushes option on the PR, anyway done now, thanks. |
in my experience sometimes it just doesn't work for unknown reasons. Thanks for the fix! |
When
--pst-font-size-baseis small (i.e. 12px) the search icons (magnifying-glass and keyboard shortcut hint) could appear outside the search bar because their positions did not take the negative margins of their parent container into account.Use css
calc()to include it now.TBH I don't know why a padding + negative margin is employed on the form element. Online I found that this technique can be used to make just one element (like a header) not constrained by the padding, but here there is only one child element (the
<form>). The commit history doesn't help either since the stylesheet had this since it's first version.Before (300% zoom +
--pst-font-size-base: 0.33remto exaggerate the problem):After:
