Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix footer appearing on top for short pages #1277

Merged
merged 1 commit into from Apr 12, 2023

Conversation

Maetveis
Copy link
Contributor

@Maetveis Maetveis commented Apr 1, 2023

Fixes: #1276

@Maetveis
Copy link
Contributor Author

Maetveis commented Apr 1, 2023

Its easy to see the difference on the "Read the Docs functionality" page. Compare this PR vs main

@drammock
Copy link
Collaborator

drammock commented Apr 4, 2023

I think this is actually intended behavior? (@choldgraf can confirm perhaps)

According to the docs

The article footer exists just below your page’s article, and is primarily used for navigating between adjacent sections / pages.

If you don't want prev/next to appear there, you can move the prev/next template, something like this:

html_theme_options = {
  ...
  "article_footer_items": [],
  "content_footer_items": ["prev-next.html"],
  ...
}

If you agree that this solves the problem, please close this issue, otherwise let us know (maybe I'm misunderstanding).

@drammock drammock added the needs: more information Needs more information from the author before we can move forward label Apr 11, 2023
@Maetveis
Copy link
Contributor Author

I think this is actually intended behavior? (@choldgraf can confirm perhaps)

I don't agree, #1215 changed the behavior (footer no longer sticks to bottom of page), but I don't think that change was intentional; from the description of #1215:

It doesn't change any end-user behavior, other than these sections now being configurable.

This is as explicit as it gets. Now I don't want to force the previous position if this change really way intentional or if it is decided to be kept, but personally I think the previous behavior made more sense, and this is just an accidental regression.

According to the docs

The article footer exists just below your page’s article, and is primarily used for navigating between adjacent sections / pages.

I don't think "just below" was meant to be read as without any space between the two, but instead as there will be no intervening elements between the two.

@drammock
Copy link
Collaborator

ok I'm convinced now that this wasn't an intended change in #1215. Thanks for fixing it!

@drammock drammock merged commit a9ac168 into pydata:main Apr 12, 2023
14 checks passed
Copy link
Collaborator

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling is that this PR achieves the behavior that we want - I think it makes sense to snap these menu items to the bottom of the page 👍

@Maetveis Maetveis deleted the fix_footer_top branch April 12, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: more information Needs more information from the author before we can move forward
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Article footer appears on the top of page
3 participants