Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop using squared icon for github and twitter #1250

Merged
merged 15 commits into from Apr 13, 2023
Merged

fix: stop using squared icon for github and twitter #1250

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0d2019b
fix: use the python icon
12rambau Mar 15, 2023
0c7a494
fix: use custom icons for icon_links
12rambau Mar 15, 2023
915911b
change icon colors
12rambau Mar 15, 2023
c874de4
remove coloring of the icons
12rambau Apr 5, 2023
75e68c8
use custom icon for pypi
12rambau Apr 11, 2023
609d278
Update docs/_static/custom.js
12rambau Apr 12, 2023
36ee726
update icon name
12rambau Apr 12, 2023
9879405
resize icons
12rambau Apr 12, 2023
0aee51b
cleaning
12rambau Apr 12, 2023
5e61af0
Merge branch 'main' into icons
12rambau Apr 12, 2023
0ef3d61
cleaning
12rambau Apr 12, 2023
67a5789
update tests
12rambau Apr 12, 2023
24e869b
merge typo
12rambau Apr 12, 2023
d4ebd9f
Update docs/_static/custom-icon.js
drammock Apr 13, 2023
f15314e
Update docs/_static/custom-icon.js
drammock Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions docs/_static/custom.js
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a clearer filename like custom-icons.js or fontawesome-extra-icons.js or something like that?

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

17 changes: 14 additions & 3 deletions docs/conf.py
View file
Open in desktop
Expand Up @@ -118,14 +118,24 @@
"name": "Donate to NumFocus",
},
],
"github_url": "https://github.com/pydata/pydata-sphinx-theme",
"twitter_url": "https://twitter.com/PyData",
# "github_url": "https://github.com/pydata/pydata-sphinx-theme",
# "twitter_url": "https://twitter.com/PyData",
12rambau marked this conversation as resolved.
Show resolved Hide resolved
"header_links_before_dropdown": 4,
"icon_links": [
{
"name": "Twitter",
"url": "https://twitter.com/PyData",
"icon": "fa-brands fa-twitter",
},
{
"name": "GitHub",
"url": "https://github.com/pydata/pydata-sphinx-theme",
"icon": "fa-brands fa-github",
},
{
"name": "PyPI",
"url": "https://pypi.org/project/pydata-sphinx-theme",
"icon": "fa-solid fa-box",
"icon": "fac fa-list-old-style",
12rambau marked this conversation as resolved.
Show resolved Hide resolved
},
{
"name": "PyData",
Expand Down Expand Up @@ -196,6 +206,7 @@
# so a file named "default.css" will overwrite the builtin "default.css".
html_static_path = ["_static"]
html_css_files = ["custom.css"]
html_js_files = ["custom.js"]
todo_include_todos = True

# -- favicon options ---------------------------------------------------------
Expand Down