Search keyboard shortcut ⌘ + K not working in Dvorak

[gabalafou]

Steps to reproduce

The following steps will assume that your physical keyboard is labelled according to the QWERTY layout. For this test, it is important to keep the following key map in mind:

QWERTY	Dvorak
K	T
V	K

1. At the OS level, choose the Dvorak keyboard layout
2. Using Chrome browser, go to PyData Theme
3. Press control + V (Dvorak maps this key to the letter "K")
   Result: nothing
4. Press control + K (Dvorak maps this key to the letter "T")
   Result: opens new browser tab
5. On Mac, press control (not command) + K
   Result: opens search dialog

Expected behavior

Pressing control + the key mapped to "K" in Dvorak (rather than the key mapped to "K" in QWERTY) should open the search dialog.

[12rambau]

I have been using AZERTY (fr-iso) layout my all life and didn't experience any issues even though the k is 1 letter to the left of the en-iso mapping.

[gabalafou]

Wait what? If I do an image search for AZERTY keyboards, I see the K in the exact same position as QWERTY. See for example the Wikipedia entry on AZERTY and compare with QWERTY. In both, I see that the K key is 8 keys to right of the caps lock key.

[12rambau]

I was counting the number of letters from "Enter" but you effectively have 1 extra key for special characters,

[gabalafou]

Mystery solved. The K key on your keyboard gets reported as event.code === 'KeyK' (check your key's code), and as #1525 shows, the code handling the keyboard shortcut was erroneously using event.code (should use event.key instead).