Ctrl-K or Cmd-K don't activate search for me

[jni]

On macOS Firefox, it seems to be a browser shortcut and it just starts searching DDG (my default search engine) on the browser address bar. 😕 I thought it might be my StopTheMadness extension but I see the same thing even if I disable it.

[melissawm]

Ok - it works for me on firefox/Linux but I'll try to find an explanation. I do however see the accent color is wrong so I'll fix that in the meantime:

[jni]

To be honest I wouldn't mind if the shortcut wasn't there just taunting me... 😂 any chance we can disable the display of it? Well, at least if it turns out to be a widespread problem... Would be good to get a couple of more testers... @psobolewskiPhD?

[psobolewskiPhD]

macOS 13.5.1 here
Safari 17.0 it shows control-K and both control-K and command-K work
Chrome (118.0.5993.88 (Official Build) (arm64)) it shows command-K and both work.

[jni]

@melissawm maybe don't follow my advice to remove the shortcut display, since I appear to be an outlier? Let's just leave this issue open in case others find it. If it's reproduced, we can think about removing it. Thank you!

[jni]

And thanks @psobolewskiPhD for the fast response!

[melissawm]

no worries, this is pretty easy to turn on and off! I can leave it there and we'll investigate further.

[jni]

Ha! I figured it out!!!!! Totally randomly! 🤣

I happened to have the NetworkX docs open. I pressed Cmd-Shift-T to reopen a closed tab and... It instead focused on the search box! What! 🤯

So I glanced at the keyboard (actually @jamesyan-git's next to me because mine has the keycaps moved around) and found that in Dvorak the Qwerty K is remapped to T — and I use the Dvorak layout!

So it seems that this is a bug in the pydata sphinx theme proper and that whatever library they are using to detect key bindings doesn't respect OS-level remapping. I'll raise an issue there!

[jni]

omg and it literally just got fixed upstream! 🤣👏👏👏

pydata/pydata-sphinx-theme#1521

This is precisely why this port you are doing is so important, @melissawm! 🙏 🚀

[jni]

This issue was also interesting:

pydata/pydata-sphinx-theme#1499

I like the discussion there: if the shortcut shows after you've clicked on search the first time, then that is enough. Perhaps we can follow the advice on that issue to only show the search icon, as long as you get "cmd-K" in the full search box when activated? But anyway that's for post-merge discussion imho, not a big deal.