New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pip commands to install 1.10 #6930
Conversation
f01260b
to
71f9a9d
Compare
please review |
@@ -33,7 +33,7 @@ To make contributing as easy and fast as possible, you'll want to run tests and | |||
*pydantic* has few dependencies, doesn't require compiling and tests don't need access to databases, etc. | |||
Because of this, setting up and running the tests should be very simple. | |||
|
|||
You'll need to have a version between **Python 3.7 and 3.11**, **virtualenv**, **git**, and **make** installed. | |||
You'll need to have a version between **Python 3.7 and 3.11**, **virtualenv**, **git**, **pdm** and **make** installed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't have pdm
in V1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make install
failed without pdm being installed so I added it. Do you still want me to remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. Sorry!
Thanks @chbndrhnns 🙏 Just left a small comment. Other than that LGTM please update |
Change Summary
The installation instructions are incomplete for v1:
git+https
, notgit+git
Related issue number
Checklist
Selected Reviewer: @hramezani