Deque's maxlen property dropped on V1 validation #6586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please add one line description on changefile |
|
Sorry! forgot about that. |
|
please review |
hramezani
approved these changes
Jul 11, 2023
|
Thanks @maciekglowka |
|
Thanks for merging so fast :) |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Initial proposal to fix the
maxlenproperty being dropped ondequevalidation. Happened only if the deque item has been typed.Fix happens only in the
_validate_sequence_likefunc. Do not know pydantic's code base, so if there is a neater place / way to solve it I am more than happy to make a change if directedRelated issue number
fix #6581
Selected Reviewer: @PrettyWood