Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📌 Use Cython < v3 #5845

Merged
merged 1 commit into from May 24, 2023
Merged

📌 Use Cython < v3 #5845

merged 1 commit into from May 24, 2023

Conversation

lig
Copy link
Contributor

@lig lig commented May 24, 2023

Change Summary

Discourage usage of Cython 3 with Pydantic 1.x.

This fix prevents Pydantic 1.x CI crashing after Cython 3 is released.

Related issue number

Fix #5842

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI and coverage remains at 100%
  • Documentation reflects the changes where applicable
  • changes/<pull request or issue id>-<github username>.md file added describing change
    (see changes/README.md for details)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

@cloudflare-pages
Copy link

cloudflare-pages bot commented May 24, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f2a3083
Status: ✅  Deploy successful!
Preview URL: https://9ac4fad2.pydantic-docs2.pages.dev
Branch Preview URL: https://5842-pin-cython0x.pydantic-docs2.pages.dev

View logs

@lig lig marked this pull request as ready for review May 24, 2023 11:29
@lig
Copy link
Contributor Author

lig commented May 24, 2023

please review

@samuelcolvin samuelcolvin merged commit b9a316e into 1.10.X-fixes May 24, 2023
50 checks passed
@samuelcolvin samuelcolvin deleted the 5842-pin-cython0x branch May 24, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants