[cherry-pick] Fix mypy plugin for 1.1.0 #5110
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Fix mypy plugin for 1.1.0 * Code review * Add version key to plugin data
github-actions
bot
added
cherry-pick-v1
cdce8p
reviewed
Feb 24, 2023
| BASESETTINGS_FULLNAME = 'pydantic.env_settings.BaseSettings' | ||
| MODEL_METACLASS_FULLNAME = 'pydantic.main.ModelMetaclass' |
There was a problem hiding this comment.
This seems to be an issue of the merge conflict resolution. The PR should only add MODEL_METACLASS_FULLNAME not replace BASESETTINGS_FULLNAME.
I've opened #5111 with a manual backport. Feel free to use that or close it if you'd like to change it here.
|
replcaed by #5111 |
samuelcolvin
deleted the
cherry-pick-1.10.X-fixes-6267ae3538cf7237ff6769174b4c340415e0f444
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picking #5077 onto this branch