Add test for functoool.partial validators #5102
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 23, 2023 11:27
This fixes pydantic#5101 atleast in regards to the unhelpful message As this check is only done on creation of a class the overhead should be ok
|
Also I see tests are failing. Please update. |
samuelcolvin
approved these changes
Feb 24, 2023
|
Yes I'm fine with it. If possible I think we should support functools validators in v2 (given my understanding of how validators will work in v2 though I think that should be straightforward). |
JensHeinrich
pushed a commit
to JensHeinrich/pydantic
that referenced
this pull request
Mar 1, 2023
Was suggested in python/cpython#102323 by @sobolevn. Fixes pydantic#5101 Superceedes pydantic#5102
JensHeinrich
pushed a commit
to JensHeinrich/pydantic
that referenced
this pull request
Mar 1, 2023
|
Does it make sense to close this in favor of #5126 ? |
dmontagu
added a commit
that referenced
this pull request
Mar 8, 2023
* Use getattr and default for qualname Was suggested in python/cpython#102323 by @sobolevn. Fixes #5101 Superceedes #5102 * Import tests from #5102 * Fix signature generation for functools * Use getattr and default for name * Remove expectation of error from tests * Reset tracked validators * Describe changes * Use getattr and default for module * Use id as fallback * Tweak name formatting --------- Co-authored-by: JensHeinrich <github.com/JensHeinrich> Co-authored-by: David Montague <35119617+dmontagu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add testcase for #5101