Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation of first note on mypy documentation page #10405

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

joaopalmeiro
Copy link
Contributor

@joaopalmeiro joaopalmeiro commented Sep 13, 2024

Hi! 👋

Changes summary

Before After
Screenshot 2024-09-13 at 13 42 44 Screenshot 2024-09-13 at 15 14 40

Related issue number

Fix #10403

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
  • My PR is ready to review

Selected Reviewer: @sydney-runkle

@github-actions github-actions bot added documentation relnotes-fix Used for bugfixes. labels Sep 13, 2024
@joaopalmeiro
Copy link
Contributor Author

please review

Copy link

codspeed-hq bot commented Sep 13, 2024

CodSpeed Performance Report

Merging #10405 will not alter performance

Comparing joaopalmeiro:fix-mypy-docs-note (c30678f) with main (d08eddf)

Summary

✅ 49 untouched benchmarks

Copy link
Contributor

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

@sydney-runkle sydney-runkle merged commit 6614900 into pydantic:main Sep 13, 2024
62 checks passed
@joaopalmeiro joaopalmeiro deleted the fix-mypy-docs-note branch September 13, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content of a note on the mypy documentation page outside its container
2 participants