Update pip commands to install 1.10 #6930
Merged
+11
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chbndrhnns
force-pushed
the
fix-docs
branch
3 times, most recently
from
f01260b
to
71f9a9d
Compare
|
please review |
hramezani
reviewed
Jul 28, 2023
| @@ -33,7 +33,7 @@ To make contributing as easy and fast as possible, you'll want to run tests and | |||
| *pydantic* has few dependencies, doesn't require compiling and tests don't need access to databases, etc. | |||
| Because of this, setting up and running the tests should be very simple. | |||
|
|
|||
| You'll need to have a version between **Python 3.7 and 3.11**, **virtualenv**, **git**, and **make** installed. | |||
| You'll need to have a version between **Python 3.7 and 3.11**, **virtualenv**, **git**, **pdm** and **make** installed. | |||
There was a problem hiding this comment.
I think we don't have pdm in V1
There was a problem hiding this comment.
make install failed without pdm being installed so I added it. Do you still want me to remove it?
|
Thanks @chbndrhnns 🙏 Just left a small comment. Other than that LGTM please update |
hramezani
approved these changes
Jul 28, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
The installation instructions are incomplete for v1:
git+https, notgit+gitRelated issue number
Checklist
Selected Reviewer: @hramezani