Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump jiter to 0.9, pyo3 to 0.24 #1667

Merged
merged 1 commit into from
Mar 11, 2025
Merged

bump jiter to 0.9, pyo3 to 0.24 #1667

merged 1 commit into from
Mar 11, 2025

Conversation

davidhewitt
Copy link
Contributor

Change Summary

The usual round of improvements, perhaps to be merged before releasing 2.11 beta.2 ?

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Sorry, something went wrong.

Copy link

codspeed-hq bot commented Mar 10, 2025

CodSpeed Performance Report

Merging #1667 will improve performances by 37.77%

Comparing dh/pyo3-0.24 (6ee32eb) with main (d8be765)

Summary

⚡ 1 improvements
✅ 156 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_strict_union_error_core 45.1 µs 32.8 µs +37.77%

@davidhewitt
Copy link
Contributor Author

Looks like this is overall fine, moderate perf bumps in some areas and a little perf loss in core_json_fs benchmark. I think that can be compensated for by #1620 in the future.

@davidhewitt davidhewitt requested a review from Viicos March 10, 2025 21:50
@davidhewitt
Copy link
Contributor Author

(This test_strict_union_error_core stat looks meaningless, for some reason it had a bad run on main and I think would show on all PRs.)

@davidhewitt davidhewitt merged commit aa142f9 into main Mar 11, 2025
29 checks passed
@davidhewitt davidhewitt deleted the dh/pyo3-0.24 branch March 11, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants