Add TzInfo.__new__ stub method
#1611
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hum, stubtest works even though I commented out the stub |
CodSpeed Performance ReportMerging #1611 will not alter performanceComparing Summary
|
davidhewitt
approved these changes
Jan 30, 2025
src/input/datetime.rs
Outdated
| @@ -548,6 +548,7 @@ pub struct TzInfo { | |||
| #[pymethods] | |||
| impl TzInfo { | |||
| #[new] | |||
| #[pyo3(signature = (seconds))] | |||
There was a problem hiding this comment.
I think this should be autogenerated, does the subtest still pass if you remove this?
There was a problem hiding this comment.
>>> TzInfo.__new__.__text_signature__
'($type, *args, **kwargs)'Seems like pyo3 doesn't handle __new__ signatures correctly?
There was a problem hiding this comment.
Ah, that'll be PyO3/pyo3#4326
|
Oh stubtest doesn't catch this? Hmm I wonder if it doesn't check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fixes #1605
Related issue number
Checklist
pydantic-core(except for expected changes)