Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default factories taking validated data as an argument #1491

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

Viicos
Copy link
Member

@Viicos Viicos commented Oct 22, 2024

Change Summary

Closes pydantic/pydantic#9789

Related issue number

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Sorry, something went wrong.

Copy link

codspeed-hq bot commented Oct 22, 2024

CodSpeed Performance Report

Merging #1491 will not alter performance

Comparing dependent-defaults (a6a58de) with main (1ced3e6)

Summary

✅ 155 untouched benchmarks

@Viicos Viicos force-pushed the dependent-defaults branch 2 times, most recently from a7eea93 to a3b4cf0 Compare October 22, 2024 14:01
@Viicos Viicos force-pushed the dependent-defaults branch from a3b4cf0 to a6a58de Compare October 22, 2024 15:25
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here, thanks @Viicos!

@sydney-runkle sydney-runkle merged commit ff08c20 into main Oct 23, 2024
29 checks passed
@sydney-runkle sydney-runkle deleted the dependent-defaults branch October 23, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow access to other field values when creating a default value
2 participants