Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure setup-python outputs are always included in nox cache keys #3157

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

agriyakhetarpal
Copy link
Member

Description

A follow-up to #3079 and fixes the failing Windows tests with Python 3.11 on #3108. This PR ensures that the Python version (including sub-versions and patch releases) from the outputs of the setup-python action is used to build the cache keys and invalidates previously built caches when there is a version change (i.e., from Python 3.11.3 to Python 3.11.4), making the caching more robust. See actions/setup-python#330 (comment) for more details.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (68cfb41) 99.71% compared to head (e1beba8) 99.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3157   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18751    18751           
========================================
  Hits         18697    18697           
  Misses          54       54           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @agriyakhetarpal!

@Saransh-cpp Saransh-cpp merged commit 6f20fab into pybamm-team:develop Jul 18, 2023
19 of 21 checks passed
@agriyakhetarpal agriyakhetarpal deleted the nox-cache-fix branch July 18, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants